chore: update dep remove hard coded deps#59
Merged
runreal-warman merged 2 commits intomainfrom Apr 14, 2025
Merged
Conversation
| import * as path from '@std/path' | ||
| import { $ } from '@david/dax' | ||
| import type { Command } from '@cliffy/command' | ||
| import type * as path from '@std/path' |
There was a problem hiding this comment.
TypeScript does not support type-only namespace imports. Remove the 'type' keyword or refactor the import to use named type-only imports if only types are needed.
Suggested change
| import type * as path from '@std/path' | |
| import * as path from '@std/path' | |
| import type { PathLike, ParsedPath } from '@std/path' |
There was a problem hiding this comment.
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (1)
- deno.jsonc: Language not supported
Comments suppressed due to low confidence (2)
src/commands/uasset/parse.ts:103
- Ensure that the additional double space in the template literal is intentional, as it may affect the parsing logic if extra whitespace is not expected.
complexValue += ` ${lines[i].trim()}`
src/commands/script.ts:7
- Verify that the local 'esbuild' dependency is correctly installed and available in the project as the removal of the URL-based import may lead to module resolution issues.
import * as esbuild from 'esbuild'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.